Skip to content

Fix tooltip arrow alignment on rtl#35864

Closed
GeoSot wants to merge 1 commit intomainfrom
gs/fix-tooltip-arrow-in-rtl
Closed

Fix tooltip arrow alignment on rtl#35864
GeoSot wants to merge 1 commit intomainfrom
gs/fix-tooltip-arrow-in-rtl

Conversation

@GeoSot
Copy link
Copy Markdown
Member

@GeoSot GeoSot commented Feb 17, 2022

It seems is a regression of #32692, after tooltip.js cleanup .

@twbs/css-review need your help here

Thanks to @ffoodd #34627 (comment)

@GeoSot GeoSot requested a review from a team as a code owner February 17, 2022 08:52
Copy link
Copy Markdown
Contributor

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using [dir] is not correct since it would output useless CSS in our dist files.
I'll have a look at it ASAP, if it's only CSS I should be able to take care of it 🙂

@GeoSot
Copy link
Copy Markdown
Member Author

GeoSot commented Feb 17, 2022

Probably the same issue exists on popover. Please feel free to change it as you believe better

It is a bit strange as I didn't changed the css classes 😕

@GeoSot
Copy link
Copy Markdown
Member Author

GeoSot commented Feb 28, 2022

Closing in favor of #35918

@GeoSot GeoSot closed this Feb 28, 2022
@GeoSot GeoSot deleted the gs/fix-tooltip-arrow-in-rtl branch March 13, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants