Skip to content

RTL arrows for popovers and tooltips#35918

Merged
mdo merged 1 commit intomainfrom
fix/rtl-arrows
Mar 1, 2022
Merged

RTL arrows for popovers and tooltips#35918
mdo merged 1 commit intomainfrom
fix/rtl-arrows

Conversation

@ffoodd
Copy link
Copy Markdown
Contributor

@ffoodd ffoodd commented Feb 28, 2022

Replacement for / closes #35864

Not quite sure what happened there, but ignoring the whole .bs-*-start and .bs-*-end from RTLCSS seems to fix this.


Preview: https://deploy-preview-35918--twbs-bootstrap.netlify.app/docs/5.1/examples/cheatsheet-rtl/#popovers

@ffoodd ffoodd requested a review from a team as a code owner February 28, 2022 16:15
@GeoSot
Copy link
Copy Markdown
Member

GeoSot commented Feb 28, 2022

Not quite sure what happened there, but ignoring the whole .bs--start and .bs--end from RTLCSS seems to fix this.

Cause we already, already force popper to work the opposite way . (During the previous implementation, we were doing the same thing, but as I can see, we were tweaking classes over popper configuration)

Thank you for this @ffoodd , you helped me understand the reason

@mdo mdo force-pushed the fix/rtl-arrows branch from 2108c59 to 7fbcd62 Compare March 1, 2022 03:22
@mdo mdo merged commit a9d1ab2 into main Mar 1, 2022
@mdo mdo deleted the fix/rtl-arrows branch March 1, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants