Doc: fix offset content from fixed navbar when jumping to headings#36280
Doc: fix offset content from fixed navbar when jumping to headings#36280julien-deramond wants to merge 2 commits intotwbs:mainfrom
Conversation
There was a problem hiding this comment.
If I remember well, the removal of this property was to avoid the unexpected scrolling while typing into the search bar. (#33993)
There was a problem hiding this comment.
Oh I see! I put this PR in Draft mode in order to find a better solution. Any help would be helpful if you have some ideas.
There was a problem hiding this comment.
Rebased it on main. With the new DocSearch v3 system, we don't have this issue anymore since there is a popup instead of a typeahead. It seems to work pretty well in desktop and mobile modes.
There was a problem hiding this comment.
Clicking the version dropdown picker also causes a scrolling issue—each time you click it, the page moves up a bit.
There was a problem hiding this comment.
Argh. OK I see it on mobile. Opening the offcanvas menu, each time I click outside of it makes the page moves up a bit.
julien-deramond
force-pushed
the
main-jd-fix-offset-content
branch
from
68ee6ca to
04a5353
Compare
julien-deramond
force-pushed
the
main-jd-fix-offset-content
branch
from
04a5353 to
4682f6f
Compare
| } | ||
|
|
||
| .bd-content { | ||
| > h2:not(:first-child) { |
There was a problem hiding this comment.
Maybe just > h2 could be a quick fix to handle it on a stable version (even if it changes a bit the first h2 margin-top) or maybe add an !important rule to the code above ?
|
Superseded by #38220 |
3 participants
Closes #36278
This PR is a suggestion to fix the issue #36278.
I've reverted the change from 195440f to include what was there before.
Few changes:
media-breakpoint-up(md)rule4remto use the new value5remLive previews examples
/CC @mdo (maybe there are edge cases that I'm not aware of)