Skip to content

Docs: Proposal to use scroll-margin-top instead padding and margin#38220

Merged
mdo merged 1 commit intomainfrom
main-lmp-handle-scroll-target
Mar 20, 2023
Merged

Docs: Proposal to use scroll-margin-top instead padding and margin#38220
mdo merged 1 commit intomainfrom
main-lmp-handle-scroll-target

Conversation

@louismaximepiton
Copy link
Copy Markdown
Member

@louismaximepiton louismaximepiton commented Mar 13, 2023

Description

Use the newly approved CSS property for :target

Motivation & Context

remove some small shifts introduced in the doc.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (NA) My change introduces changes to the documentation
  • (NA) I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #36278.
Superseed #36280.

@julien-deramond
Copy link
Copy Markdown
Member

Might superseed #36280 and close #36278

Copy link
Copy Markdown
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

Doc: Extra top padding after having clicked on anchor links

3 participants