Skip to content

Docs: Remove unnecessary href and tabindex="-1"#38196

Merged
mdo merged 2 commits intomainfrom
main-lmp-disabled-links
Mar 10, 2023
Merged

Docs: Remove unnecessary href and tabindex="-1"#38196
mdo merged 2 commits intomainfrom
main-lmp-disabled-links

Conversation

@louismaximepiton
Copy link
Copy Markdown
Member

Description

Remove unnecessary href and tabindex="-1". The ones remaining in the buttons and in the interactions seem pretty legit for me.

Motivation & Context

Coherence inside the doc.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

Comment thread site/content/docs/5.3/components/placeholders.md
@mdo mdo merged commit 2032a6a into main Mar 10, 2023
@mdo mdo deleted the main-lmp-disabled-links branch March 10, 2023 17:17
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants