Skip to content

Docs: Remove unnecessary href and tabindex="-1" #38196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdo merged 2 commits into from
Mar 10, 2023
Merged

Docs: Remove unnecessary href and tabindex="-1" #38196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b15a7c
Proposal
louismaximepiton Mar 8, 2023
73ca809
fix(review)
louismaximepiton Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions site/content/docs/5.3/components/placeholders.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ In the example below, we take a typical card component and recreate it with plac
<span class="placeholder col-6"></span>
<span class="placeholder col-8"></span>
</p>
<a href="#" tabindex="-1" class="btn btn-primary disabled placeholder col-6"></a>
<a class="btn btn-primary disabled placeholder col-6"></a>
</div>
</div>
</div>
Expand Down Expand Up @@ -67,7 +67,7 @@ In the example below, we take a typical card component and recreate it with plac
<span class="placeholder col-6"></span>
<span class="placeholder col-8"></span>
</p>
<a href="#" tabindex="-1" class="btn btn-primary disabled placeholder col-6"></a>
<a class="btn btn-primary disabled placeholder col-6"></a>
</div>
</div>
```
Expand All @@ -83,7 +83,7 @@ We apply additional styling to `.btn`s via `::before` to ensure the `height` is
<span class="placeholder col-6"></span>
</p>

<a href="#" tabindex="-1" class="btn btn-primary disabled placeholder col-4" aria-hidden="true"></a>
Comment thread
mdo marked this conversation as resolved.
<a class="btn btn-primary disabled placeholder col-4"></a>
{{< /example >}}

{{< callout info >}}
Expand Down