Skip to content

upgrade versions of things to correspond with the modern day#47

Merged
twm merged 8 commits intotrunkfrom
new-version-2026
Apr 25, 2026
Merged

upgrade versions of things to correspond with the modern day#47
twm merged 8 commits intotrunkfrom
new-version-2026

Conversation

@glyph
Copy link
Copy Markdown
Member

@glyph glyph commented Apr 23, 2026

Let's get a release done this year; for starters, let's get things working on modern Python.

@glyph glyph requested a review from a team April 23, 2026 18:15
@glyph
Copy link
Copy Markdown
Member Author

glyph commented Apr 23, 2026

@adiroiban if you can have a look at this and get a release out it would probably be good

@glyph glyph mentioned this pull request Apr 23, 2026
Copy link
Copy Markdown
Member

@twm twm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@twm
Copy link
Copy Markdown
Member

twm commented Apr 25, 2026

I'll go ahead and merge this so that #46 can build.

@twm twm merged commit e5b311f into trunk Apr 25, 2026
10 checks passed
Copy link
Copy Markdown
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now see that I forgot to send the review :(

I know it's too late.
Just in case it help someone.

Comment thread .github/workflows/ci.yaml

- name: Upload coverage data
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v7
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good..

But since we are at it...maybe also update these actions, since they run with older Node.js versions and at some point they will stop working.

-actions/checkout@v3
+actions/checkout@v6

-actions/setup-python@v4
+actions/setup-python@v6

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed up with #48

@twm twm mentioned this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants