Skip to content

upgrade versions of things to correspond with the modern day #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twm merged 8 commits into from
Apr 25, 2026
+12 −12
Merged

upgrade versions of things to correspond with the modern day #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fdf76ef
upgrade versions of things to correspond with the modern day
glyph Apr 23, 2026
a80fd2e
more upgrades
glyph Apr 23, 2026
f95ef75
probably an old version of coverage artifact
glyph Apr 23, 2026
5773faf
parallel
glyph Apr 23, 2026
5c95c0e
another upgrade
glyph Apr 23, 2026
a8bc6c7
why are these files not present
glyph Apr 23, 2026
102d367
is this the thing
glyph Apr 23, 2026
2337c9a
remove debugging
glyph Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ defaults:

env:
# The default values in the job generated by the matrix.
DEFAULT_PYTHON_VERSION: '3.11'
DEFAULT_PYTHON_VERSION: '3.13'

jobs:
testing:
Expand All @@ -44,7 +44,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
python-version: ['3.10', '3.11', '3.12', '3.13', '3.14']

steps:
- uses: actions/checkout@v3
Expand All @@ -67,15 +67,15 @@ jobs:

- name: Test code
run: |
coverage run -m twisted.trial constantly
mv .coverage .coverage.${{ matrix.python-version }}
coverage run -p -m twisted.trial constantly

- name: Upload coverage data
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v7
Copy link
Copy Markdown
Member

@adiroiban adiroiban Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good..

But since we are at it...maybe also update these actions, since they run with older Node.js versions and at some point they will stop working.

-actions/checkout@v3
+actions/checkout@v6

-actions/setup-python@v4
+actions/setup-python@v6

Copy link
Copy Markdown
Member

@twm twm Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed up with #48

with:
name: coverage-data
path: .coverage.*
if-no-files-found: error # 'warn' or 'ignore' are also available.
include-hidden-files: true


coverage:
Expand All @@ -88,11 +88,11 @@ jobs:
- uses: actions/setup-python@v4
with:
# Use latest Python, so it understands all syntax.
python-version: 3.11
python-version: 3.14

- run: python -Im pip install --upgrade coverage[toml]

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v8
with:
name: coverage-data

Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:

apidocs:
name: API docs build
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v3
- name: Set up Python
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ classifiers = [
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
"Topic :: Software Development :: Libraries :: Python Modules",
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = {py27,pypy,py33,py34}-tests, pyflakes, cov, docs
envlist = {pypy,py310,py311,py312,py313,py314}-tests, pyflakes, cov, docs

[testenv]
changedir = {envtmpdir}
Expand Down Expand Up @@ -29,7 +29,7 @@ commands = {envbindir}/pyflakes {toxinidir}/constantly

[testenv:docs]
deps = sphinx
basepython = python2.7
basepython = python3.14
commands =
{envbindir}/sphinx-build -W -b html {toxinidir}/docs {toxinidir}/docs/_build/html

Expand Down
Loading