feat(utxo-rpc): Add support for BlockFetch by Slot or Height and DumpHistory to support BlockHeight#154
Closed
Mercurial wants to merge 1 commit intotxpipe:mainfrom
Closed
Conversation
Contributor
Author
|
nvm as per discussion with Santi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work In Progress to support block fetch not only by hash but also by Slot or Height.
As of right now only fetching by block hash is supported.
Aswell as
next_tokenin theDumpHistoryResponseneeds to support Block->Height according to theBlockRefstructure in the U5C specification.I'm thinking this would need some kind of new KeyValueStore within
pallas-rolldbsimiliar toit could be something like
but I think the main hurdle is that the block height / number doesn't seem to be a first-class-citizen field within the pipeline.
Looking for feedback / suggestions