fix(serve): handle new spec block-structure changes#504
Open
lancevincentsalera wants to merge 12 commits intotxpipe:mainfrom
Open
fix(serve): handle new spec block-structure changes#504lancevincentsalera wants to merge 12 commits intotxpipe:mainfrom
lancevincentsalera wants to merge 12 commits intotxpipe:mainfrom
Conversation
…d add height field
…ter and handle block height retrieval
…ndling in related functions
lancevincentsalera
changed the title
…k body in ReadTipResponse
…_tip_response to decode block height directly from RawBlock
…pe and improve error handling for block decoding
…ht directly and improve response handling
| .intersect | ||
| .iter() | ||
| .map(|x| ChainPoint::Specific(x.index, x.hash.to_vec().as_slice().into())) | ||
| .map(|x| ChainPoint::Specific(x.slot, x.hash.to_vec().as_slice().into())) |
Contributor
There was a problem hiding this comment.
This PR properly adds the changes in the output, but isn't handling the new behavior in the input. The goal of #154 is that you should be able to create requests on more than just the slot number (since you might only know the block height, or only know the block hash)
Contributor
Author
There was a problem hiding this comment.
Hello @SebastienGllmt , thanks for this. I made changes to the fetchBlock endpoint, can you check if the implementation has more to improve or looks good already? I tested this on my side and it works fine now. Many thanks!
scarmuega
force-pushed
the
main
branch
2 times, most recently
from
295b558 to
09d0b81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses spec block structure changes from utxorpc/spec#155 and utxorpc/spec#154.
CC: @SebastienGllmt, @scarmuega