feat: add environment variables for public-facing URLs #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow overriding public URLs via environment variables when running behind a reverse proxy. This fixes an issue where the UI would try to connect to bind addresses (e.g., http://0.0.0.0:8899) instead of the public-facing URLs. The UI runs in the browser (client-side) and needs to know the public URLs to connect back to the API, not the internal bind addresses used by the Docker container. New environment variables: - SURFPOOL_PUBLIC_RPC_URL: Public RPC endpoint URL - SURFPOOL_PUBLIC_WS_URL: Public WebSocket endpoint URL - SURFPOOL_PUBLIC_STUDIO_URL: Public Studio UI URL Also fix Dockerfile to expose correct port 18488 instead of outdated 8488. (cherry picked from commit b14aa71)
lgalabru
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overriding public URLs via environment variables when running behind a reverse proxy. This fixes an issue where the UI would try to connect to bind addresses (e.g., http://0.0.0.0:8899) instead of the public-facing URLs.
The UI runs in the browser (client-side) and needs to know the public URLs to connect back to the API, not the internal bind addresses used by the Docker container.
New environment variables:
SURFPOOL_PUBLIC_RPC_URL: Public RPC endpoint URLSURFPOOL_PUBLIC_WS_URL: Public WebSocket endpoint URLSURFPOOL_PUBLIC_STUDIO_URL: Public Studio UI URLAlso fix Dockerfile to expose correct port 18488 instead of outdated 8488.