Skip to content

feat: add environment variables for public-facing URLs #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgalabru merged 1 commit into from
Oct 20, 2025
Merged

feat: add environment variables for public-facing URLs #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ COPY --from=build /out/ /bin/

WORKDIR /workspace

EXPOSE 8899 8900 8488
EXPOSE 8899 8900 18488

# Create a shell script that provides default behavior
RUN echo '#!/bin/bash\n\
Expand Down
13 changes: 10 additions & 3 deletions crates/cli/src/cli/simnet/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,16 @@ pub async fn handle_start_local_surfnet_command(
let config = cmd.surfpool_config(airdrop_addresses);

let studio_binding_address = config.studio.get_studio_base_url();
let rpc_url = format!("http://{}", config.rpc.get_rpc_base_url());
let ws_url = format!("ws://{}", config.rpc.get_ws_base_url());
let studio_url = format!("http://{}", studio_binding_address);

// Allow overriding public-facing URLs via environment variables
// This is useful when running behind a reverse proxy (e.g., Caddy, nginx)
let rpc_url = std::env::var("SURFPOOL_PUBLIC_RPC_URL")
.unwrap_or_else(|_| format!("http://{}", config.rpc.get_rpc_base_url()));
let ws_url = std::env::var("SURFPOOL_PUBLIC_WS_URL")
.unwrap_or_else(|_| format!("ws://{}", config.rpc.get_ws_base_url()));
let studio_url = std::env::var("SURFPOOL_PUBLIC_STUDIO_URL")
.unwrap_or_else(|_| format!("http://{}", studio_binding_address));

let graphql_query_route_url = format!("{}/workspace/v1/graphql", studio_url);
let rpc_datasource_url = config.simnets[0].get_sanitized_datasource_url();

Expand Down