Add support for patch_minor when detecting Chrome.#322
Merged
commenthol merged 2 commits intoua-parser:masterfrom Sep 14, 2018
Merged
Add support for patch_minor when detecting Chrome.#322commenthol merged 2 commits intoua-parser:masterfrom
commenthol merged 2 commits intoua-parser:masterfrom
Conversation
|
Would love to get this as Google Analytics browser_version data shows the patch_minor for chrome while ua-parser output currently does not. |
Contributor
|
Was this ever integrated for real? The spec was not updated, it looks like the test driver for the reference implementation ( Shouldn't this be backed out? Or finished "for real"? |
This was referenced Apr 20, 2024
lbarthon
pushed a commit
that referenced
this pull request
Apr 23, 2024
`patch_minor` was added to regexes and some test_ua entries in #322. Neither spec nor reference implementation were ever updated for it, so many regexes were merged (?) with a capture for `patch_minor` but without correctly asserting it, and a pair of cases specify a `patch_minor` which is not captured: - the facebook regex[^1] only has 4 capturing groups - same for the AWS regex[^2] [^1]: https://github.com/ua-parser/uap-core/blob/959e106754828ae557b0dbcfaf8eeee938d3c824/regexes.yaml#L176 [^2]: https://github.com/ua-parser/uap-core/blob/959e106754828ae557b0dbcfaf8eeee938d3c824/regexes.yaml#L155
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should, I believe, resolve #22.