Skip to content

UserAgentParser does not support patch_minor, but patch_minor is supported in uap-core #142

@geoffblack

Description

@geoffblack

The string 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.104 Safari/537.36' should parse out to

{
    'family': 'Chrome',
    'major': '41',
    'minor': '0',
    'patch': '2272',
    'patch_minor': '104'
}

but, instead, we get:

{
    'family': 'Chrome',
    'major': '41',
    'minor': '0',
    'patch': '2272'
}

User Agent patch_minor is already supported in uap-core; see ua-parser/uap-core#22 and ua-parser/uap-core#322 for an example.

UserAgentParser.Parse and _ParseUserAgent should be updated to support User Agent patch_minor, as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions