upgrade java compiler source to 1.8 and add a type annotations for Re…#198
Open
henrywoo wants to merge 2 commits intouber:masterfrom
Open
upgrade java compiler source to 1.8 and add a type annotations for Re…#198henrywoo wants to merge 2 commits intouber:masterfrom
henrywoo wants to merge 2 commits intouber:masterfrom
Conversation
Author
|
The Travis CI build failed because it is still using Java 1.7. Could anybody in charge of this project please upgrade it to 1.8? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To justify the use of
response.close()which people often use, we need to specifyNotNullfor Response, so I added a type annotation. It failed with an error:This conflicts with the comment in pom.xml:
It seems we forgot to specify java 8. So I modified it. That is how this diff comes.