Skip to content

upgrade java compiler source to 1.8 and add a type annotations for Re… #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henrywoo wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −4
Open

upgrade java compiler source to 1.8 and add a type annotations for Re… #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c47ed6
upgrade java compiler source to 1.8 and add a type annotations for Re…
shadowwalker2718 May 26, 2019
6a2bf9a
use java 8
henrywoo Jun 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ env:

matrix:
include:
- jdk: openjdk7
- jdk: openjdk8
env: CODECOV=true
- jdk: openjdk7
- jdk: openjdk8
env: CROSSDOCK=true
# - jdk: oraclejdk8

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
<!-- store method parameter names in the bytecode (java 8+) -->
<maven.compiler.parameters>true</maven.compiler.parameters>
<maven.compiler.showWarnings>true</maven.compiler.showWarnings>
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>${maven.compiler.source}</maven.compiler.target>
<!-- https://issues.apache.org/jira/browse/MCOMPILER-205 -->
<maven.compiler.useIncrementalCompilation>false</maven.compiler.useIncrementalCompilation>
Expand Down
2 changes: 1 addition & 1 deletion tchannel-core/src/main/java/com/uber/tchannel/api/SubChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ public TFuture<RawResponse> send(
return send(request, null, 0);
}

protected <V extends Response> TFuture<V> sendRequest(
protected <V extends @NotNull Response> TFuture<V> sendRequest(
Request request,
InetAddress host,
int port
Expand Down