Fix issues when using React.StrictMode#499
Closed
wallzero wants to merge 5 commits intoui-router:masterfrom
wallzero:master
Closed
Fix issues when using React.StrictMode#499wallzero wants to merge 5 commits intoui-router:masterfrom wallzero:master
wallzero wants to merge 5 commits intoui-router:masterfrom
wallzero:master
Conversation
Contributor
Author
|
Resolves #463 |
Member
|
@wallzero can you rebase this against the latest master? I updated a few dependencies |
Contributor
Author
|
Okay it should be synced with master now. |
Member
|
hmm, github is telling me that it can't be rebased due to conflicts 🤔 Worst case, we can always make a new branch/PR and cherry pick your commits |
Contributor
Author
|
Okay I'll do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In anticipation for React suspense and concurrent mode, it is advisable to test with
<React.StrictMode>and resolve any issues.<React.StrictMode>componentWillMounttocomponentDidMountUIRoutercomponent constructor tocomponentDidMount