fixes to support React.StrictMode#512
Merged
christopherthielen merged 2 commits intoui-router:masterfrom Sep 4, 2019
wallzero:master
Merged
fixes to support React.StrictMode#512christopherthielen merged 2 commits intoui-router:masterfrom wallzero:master
christopherthielen merged 2 commits intoui-router:masterfrom
wallzero:master
Conversation
|
Thanks for these fixes!This resolves console warnings in React 16.9 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves issue #463
repeat of PR #499
In anticipation for React suspense and concurrent mode, it is advisable to test with
<React.StrictMode>and resolve any issues.<React.StrictMode>componentWillMounttocomponentDidMountUIRoutercomponent constructor tocomponentDidMount