TF Straight height apparent inconsistency

[jonmaddock]

In GitLab by @skahn on Sep 23, 2019, 16:48

Summary

hr1 is used to define surfaces area for cryo system:

    tfsai = 4.0D0 * tfno * tficrn * hr1
    tfsao = 2.0D0 * tfno * tficrn * (tfleng - 2.0D0*hr1)

but not set, except to 0 in the global variable file ...

Also to sure if why the upper curved part of the inner leg length is not containing the upper curved section

Best regards

Seb

Ref : @mkovari, @jmorris-uk

Checklist

After implementing issue do the following

• Run test suite
• Does it change the output? If so, give justifications.
• Does it change the baseline 2019 run? (you may need to run on Freia)
• Merge request created

[jonmaddock]

In GitLab by @mkovari on Sep 24, 2019, 15:35

It seems that hr1 is obsolete.

It might be worth checking if there are any other obsolete TF coil geometry variables.

[jonmaddock]

In GitLab by @skahn on Sep 24, 2019, 16:23

@mkovari, as I am transforming the resistive magnet code to match the SC code structues (same subroutines/function calls), I will try to make it more consistent, and also bring a better consistency on the variables names. This is related to @jonmaddock task :)

Another question, how obsolete are tfsai and tfsao ?

Because by definietion tfsai = 0.0D0 for all our runs and tfsao = 2.0D0 * tfno * tficrn * tfleng ...

Best regards