Skip to content

Removed tfsai and tfsao from sctfcoil due to obsolete var in calcs#3209

Merged
mkovari merged 1 commit intomainfrom
935-tf-straight-height-apparent-inconsistency
May 31, 2024
Merged

Removed tfsai and tfsao from sctfcoil due to obsolete var in calcs#3209
mkovari merged 1 commit intomainfrom
935-tf-straight-height-apparent-inconsistency

Conversation

@j-a-foster
Copy link
Copy Markdown
Collaborator

@j-a-foster j-a-foster commented May 31, 2024

Description

I removed tfsai and tfsao from sctfcoil.py as they were using the variable hr1 which wasn't calculated or an input and just set to 0. A power calculation that used tfsai was then replaced with tfcryoarea based on comments in the code (which have now been removed).

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@j-a-foster j-a-foster linked an issue May 31, 2024 that may be closed by this pull request
4 tasks
@j-a-foster
Copy link
Copy Markdown
Collaborator Author

The changes in the regression tests appear to make sense to me but would like a second opinion.

@j-a-foster j-a-foster requested a review from chris-ashe May 31, 2024 09:31
@mkovari mkovari self-requested a review May 31, 2024 15:11
@mkovari
Copy link
Copy Markdown
Collaborator

mkovari commented May 31, 2024

Since the cryogenic model is pretty rubbish anyway, I don't think this deserves too much brain power. In any case it's got to be better (?) to replace a variable that was never set by one that has a value.

@mkovari mkovari merged commit dfcda59 into main May 31, 2024
@mkovari
Copy link
Copy Markdown
Collaborator

mkovari commented May 31, 2024

Please delete the branch if you are sure I haven't done something stupid.

@je-cook je-cook deleted the 935-tf-straight-height-apparent-inconsistency branch January 5, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TF Straight height apparent inconsistency

2 participants