Add back Stellarator#2868
Merged
jonmaddock merged 1 commit intoukaea:mainfrom Sep 29, 2023
Merged
Conversation
2 tasks
timothy-nunn
force-pushed
the
1855-stellarator-removed-reintroduction-plan
branch
from
a19152e to
8881672
Compare
|
Thanks! Great to see that stellarators are back in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stuartmuldrew could you please review the
blanket_neutronics(https://github.com/timothy-nunn/PROCESS/blob/1855-stellarator-removed-reintroduction-plan/process/stellarator.py#L1034C8-L1034C8) section, as this differs from the original implementation. Other than that, the rest of Stellarator has been put in as-was.