2863 review contributing guide#2892
Merged
jonmaddock merged 3 commits intomainfrom Sep 12, 2023
Merged
Conversation
jonmaddock
requested changes
Sep 8, 2023
Contributor
jonmaddock
left a comment
jonmaddock
left a comment
There was a problem hiding this comment.
This is great Tim, thanks for sorting this out; it reads much better and is up-to-date now.
jonmaddock
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have done a first iteration of how our contributing guide could look. I welcome recommendations/ changes on the new guide. This is heavily influenced by bluemira's contributing guide.
We will want to consider how changes to the CI (#2867) will affect this workflow.