Add issue and PR templates#2895
Merged
jonmaddock merged 3 commits intomainfrom Sep 12, 2023
Merged
Conversation
timothy-nunn
requested review from
jonmaddock
and removed request for
jonmaddock
jonmaddock
reviewed
Sep 8, 2023
Contributor
jonmaddock
left a comment
jonmaddock
left a comment
There was a problem hiding this comment.
These look really good Tim. I've got a few questions on the pull request template, which I feel is a bit much, but maybe this is actually useful/standard and we should be doing it. Let me know your comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think having issue templates will be a good QOL change for this repository pre-open-source. These issue templates are mostly taken from bluemira.
We should also add a PR template that reflects the proposed format of #2892.