Skip to content

Re enable integration tests#3105

Merged
timothy-nunn merged 5 commits intoukaea:mainfrom
clmould:re-enable-integration-tests
Mar 18, 2024
Merged

Re enable integration tests#3105
timothy-nunn merged 5 commits intoukaea:mainfrom
clmould:re-enable-integration-tests

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Mar 15, 2024

Description

Re-enable integration tests. Closes #2977. Skipping test_scan integration test for now until this is fixed in #3071. Removed ixc = 52 from remaining test input files as a result of #3066

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould marked this pull request as ready for review March 15, 2024 10:49
@clmould clmould requested a review from timothy-nunn March 15, 2024 10:49
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this Clair. It is important that we have these tests running on the CI.

@timothy-nunn timothy-nunn merged commit 2bb5f44 into ukaea:main Mar 18, 2024
chris-ashe pushed a commit that referenced this pull request Apr 22, 2024
* deleted commented out integration test code

* attempt at integration tests

* add -n auto -v to integration test ci

* remove vdalw from input files used in integration and unit tests

* skip test_scan
chris-ashe pushed a commit that referenced this pull request May 1, 2024
* deleted commented out integration test code

* attempt at integration tests

* add -n auto -v to integration test ci

* remove vdalw from input files used in integration and unit tests

* skip test_scan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix and re-enable integration tests in actions

2 participants