Skip to content

Added casths_fraction and casths as iteration variables#3173

Merged
timothy-nunn merged 2 commits intomainfrom
3172-add-casths_fraction-and-casths-as-iteration-variables
May 8, 2024
Merged

Added casths_fraction and casths as iteration variables#3173
timothy-nunn merged 2 commits intomainfrom
3172-add-casths_fraction-and-casths-as-iteration-variables

Conversation

@chris-ashe
Copy link
Copy Markdown
Collaborator

Description

casths_fraction and casths have now been implemented as iteration variables

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe added the TF Coil Toroidal field coil label May 2, 2024
@chris-ashe chris-ashe requested a review from timothy-nunn May 2, 2024 14:33
@chris-ashe chris-ashe linked an issue May 2, 2024 that may be closed by this pull request
@mkovari
Copy link
Copy Markdown
Collaborator

mkovari commented May 7, 2024

It would be nice at some point to add the relevant reference dimension (total coil thickness at the inner radius of the WP) to Figure 1 of the docs.

Or just the equation
total coil thickness at the inner radius of the WP = wwp1 + 2 * casths

@mkovari
Copy link
Copy Markdown
Collaborator

mkovari commented May 7, 2024

You could doo with a check to make sure that the two new iteration variables are not used at the same time.

@chris-ashe
Copy link
Copy Markdown
Collaborator Author

You could doo with a check to make sure that the two new iteration variables are not used at the same time.

I have checked and with both variables iterating there is no difference to the number of steps to convergence, as default PROCESS will still override casths if casths_fraction is defined in the input. This is explained in the docs for the user

Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation correct. Others seem happy with the change also.

@timothy-nunn timothy-nunn merged commit eef4820 into main May 8, 2024
@timothy-nunn timothy-nunn deleted the 3172-add-casths_fraction-and-casths-as-iteration-variables branch May 8, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TF Coil Toroidal field coil

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add casths_fraction and casths as iteration variables

3 participants