3091 use testbook to automate notebook testing#3188
Merged
timothy-nunn merged 6 commits intomainfrom Jun 3, 2024
Merged
Conversation
clmould
force-pushed
the
3091-use-nbmake-or-testbook-to-automate-notebook-testing
branch
from
704f7f1 to
a73cdaf
Compare
clmould
force-pushed
the
3091-use-nbmake-or-testbook-to-automate-notebook-testing
branch
from
a73cdaf to
9b3c8bb
Compare
clmould
force-pushed
the
3091-use-nbmake-or-testbook-to-automate-notebook-testing
branch
from
9b3c8bb to
1e9ab71
Compare
timothy-nunn
requested changes
Jun 3, 2024
Collaborator
There was a problem hiding this comment.
Hi Clair,
Good to have so much duplication removed. The plot proc assets arent being deleted and there is a print statement that shouldnt be there. Other than that, good to go.
Tests pass locally, quirk of our CI means integration tests dont pass on the feature branch CI, as expected.
Tim
| assert check_positive | ||
| with testbook("csv_output.ipynb", execute=True): | ||
| # Check csv file is created | ||
| print(os.getcwd()) |
Collaborator
There was a problem hiding this comment.
Should be a logger or removed
Comment on lines
+47
to
+49
| yield | ||
| plot_proc_1 = Path("../examples/plot_proc_1") | ||
| plot_proc_2 = Path("../examples/plot_proc_2") | ||
| plot_proc_3 = Path("../examples/plot_proc_3") |
timothy-nunn
approved these changes
Jun 3, 2024
timothy-nunn
deleted the
3091-use-nbmake-or-testbook-to-automate-notebook-testing
branch
mkovari
restored the
3091-use-nbmake-or-testbook-to-automate-notebook-testing
branch
5 tasks
chris-ashe
pushed a commit
that referenced
this pull request
Jul 3, 2024
* add testbook to requirements * starting testbook work * remove duplicate scan.py script in examples, test that mfile is created from scan.ipynb * use testbook for examples tests and remove duplicate .py files * stop timeout warning in test_scan * corrections from review comments
chris-ashe
pushed a commit
that referenced
this pull request
Jul 8, 2024
This reverts commit 6cd9ccc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
I confirm that I have completed the following checks: