Skip to content

3091 use nbmake or testbook to automate notebook testing#3216

Merged
timothy-nunn merged 8 commits intomainfrom
3091-use-nbmake-or-testbook-to-automate-notebook-testing
Jun 10, 2024
Merged

3091 use nbmake or testbook to automate notebook testing#3216
timothy-nunn merged 8 commits intomainfrom
3091-use-nbmake-or-testbook-to-automate-notebook-testing

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Jun 4, 2024

Description

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@timothy-nunn timothy-nunn self-requested a review June 10, 2024 09:21
@timothy-nunn timothy-nunn linked an issue Jun 10, 2024 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal changes since #3188, timeout of 10 minutes should ensure we do not need to revert this again (#3215)

@timothy-nunn timothy-nunn merged commit d8471d8 into main Jun 10, 2024
@timothy-nunn timothy-nunn deleted the 3091-use-nbmake-or-testbook-to-automate-notebook-testing branch June 10, 2024 09:35
chris-ashe pushed a commit that referenced this pull request Jul 8, 2024
* add testbook to requirements

* starting testbook work

* remove duplicate scan.py script in examples, test that mfile is created from scan.ipynb

* use testbook for examples tests and remove duplicate .py files

* stop timeout warning in test_scan

* corrections from review comments

* add timeout limits for examples notebook tests

* increase timeout on test_examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use nbmake or testbook to automate notebook testing

2 participants