Convert process initialisation routines to python#3406
Merged
timothy-nunn merged 3 commits intomainfrom Jan 8, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3406 +/- ##
==========================================
+ Coverage 29.63% 30.65% +1.02%
==========================================
Files 78 80 +2
Lines 19105 19567 +462
==========================================
+ Hits 5661 5999 +338
- Misses 13444 13568 +124 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonmaddock
approved these changes
Jan 2, 2025
Contributor
jonmaddock
left a comment
There was a problem hiding this comment.
Great, this is a nice solution.
694a5ba to
65e198e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROCESS initialisation sequence Fortran -> Python
Iteration variable initialisation sequence Fortran -> Python
initial.f90post-input pre-model call validation Fortran -> PythonThe input validations raise a
ProcessValidationError, a new exception introduced specifically for input validation errors in a first move away from the in-built error handling system. As a temporary measure, the non-level 3 errors usewarnings.warnuntil a permanent warning solution is found.This does mean that our errors and warnings will temporarily operate through two systems, however this is no different how it was in Fortran, with inconsistent use if
print/writestatements andstop 1statements.