Convert main module to python#3426
Merged
timothy-nunn merged 4 commits intomainfrom Jan 29, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3426 +/- ##
==========================================
+ Coverage 30.60% 30.83% +0.22%
==========================================
Files 80 80
Lines 19254 19322 +68
==========================================
+ Hits 5893 5958 +65
- Misses 13361 13364 +3 ☔ View full report in Codecov by Sentry. |
timothy-nunn
force-pushed
the
3425-convert-main_modulef90-to-python
branch
from
04a888b to
6453da5
Compare
Collaborator
Author
|
Draft until #3406 |
timothy-nunn
force-pushed
the
3425-convert-main_modulef90-to-python
branch
from
6453da5 to
b53ad03
Compare
timothy-nunn
changed the title
jonmaddock
approved these changes
Jan 14, 2025
timothy-nunn
force-pushed
the
3425-convert-main_modulef90-to-python
branch
from
b53ad03 to
81c95c9
Compare
timothy-nunn
force-pushed
the
3425-convert-main_modulef90-to-python
branch
from
81c95c9 to
d57859b
Compare
ajpearcey
pushed a commit
that referenced
this pull request
Feb 26, 2025
* Convert run_summary to Python * Remove unused code in main_module.f90 * Move verror to scan.f90 * Fix timezone issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
main_module.f90to Python.I have chosen not to output the
commsg(commit message) anymore to the MFile, hence the regression failures. This is because I do not believe the information is useful, its often truncated, and it should be possible to find the commit message by the commit hash included in the Git tag.