Replaced stellarator only variable with tokamak used variable#3537
Closed
Replaced stellarator only variable with tokamak used variable#3537
Conversation
timothy-nunn
requested changes
Feb 12, 2025
Collaborator
timothy-nunn
left a comment
timothy-nunn
left a comment
There was a problem hiding this comment.
Failure in unit tests
https://github.com/ukaea/PROCESS/actions/runs/13260295171/job/37015259404?pr=3537#step:6:815
Need to rebase onto main and update the helias_5b.IN.DAT and stellarator_helias_once_through.IN.DAT files similar to what you did with the old input file.
…lace denw in fwbs variables
…y across the codebase
…ncy across the codebase
…y across the codebase
…oss the codebase
…ross the codebase
…ency across the codebase
…ncy across the codebase
…cy across the codebase
…oss the codebase
…ross the codebase
… and consistency
chris-ashe
force-pushed
the
update_blanket_variables_for_clarity
branch
from
ca28692 to
cfb9d8e
Compare
kj5248
force-pushed
the
jmatthews/3109-coolant-channels-within-the-tokamak-and-stellarator-models
branch
from
d68c85e to
193441c
Compare
chris-ashe
force-pushed
the
update_blanket_variables_for_clarity
branch
5 times, most recently
from
9109f45 to
724c025
Compare
Base automatically changed from
update_blanket_variables_for_clarity
to
main
February 18, 2025 15:26
Collaborator
Author
|
Was easier to make the changes in a fresh branch than resolving the merge conflicts from the various rebasing, so this will be closed and is resolved in #3580 |
kj5248
deleted the
jmatthews/3109-coolant-channels-within-the-tokamak-and-stellarator-models
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3109
Description
In stellarator there were variables afwi and afwo for the coolant inner channel radius for the FW inboard and outboard respectively. These variables seemed to have the same value in all the stellarator files and is comparable to the tokamak variable radius_fw_channel which is the inner channel radius for the FW (inboard and outboard).
For this reason, and to also allow for the potential of using the dcll blanket model with the stellarator, these variables were replaced with the tokamak variable radius_fw_channel.
Also had to make a change to the stellarator regression file as the default value for afwi and afwo was 0.008 rather than the default of radius_fw_channel which is 0.006.
Checklist
I confirm that I have completed the following checks: