Replace stellarator only variable for first wall coolant channel with general use variable #3580
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
=======================================
Coverage 31.74% 31.74%
=======================================
Files 85 85
Lines 20161 20161
=======================================
Hits 6400 6400
Misses 13761 13761 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
left a comment
There was a problem hiding this comment.
Rebase onto main. Are we expecting the value changes in the regression test if this a variable rename (could be fixed by rebasing onto main).
6394900 to
271ad7a
Compare
|
Regression failures (except Stellarator files) are caused by #3602 Stellarator regression test differences are being caused by what I suspect to be a bug in the stellarator. PROCESS/process/stellarator.py Lines 347 to 349 in 204b622 However, radius_fw_channel was at its default value of 0.006. Following this change, radius_fw_channel is 0.008 at this point in the code. Testing by replacing this use of radius_fw_channel with 0.006 causes the regression tests to pass.
I believe that this changes the code to be correct and the use of |
Closes #3109
Description
In stellarator there were variables afwi and afwo for the coolant inner channel radius for the FW inboard and outboard respectively. These variables seemed to have the same value in all the stellarator files and is comparable to the tokamak variable radius_fw_channel which is the inner channel radius for the FW (inboard and outboard).
For this reason, and to also allow for the potential of using the dcll blanket model with the stellarator, these variables were replaced with the tokamak variable radius_fw_channel.
Also had to make a change to the stellarator regression file as the default value for afwi and afwo was 0.008 rather than the default of radius_fw_channel which is 0.006.
Closes #3109
Checklist
I confirm that I have completed the following checks: