Add switch to toggle strict inequality convergence criteria in VMCON#3858
Merged
timothy-nunn merged 1 commit intomainfrom Sep 25, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3858 +/- ##
=======================================
Coverage 46.67% 46.67%
=======================================
Files 122 122
Lines 27806 27809 +3
=======================================
+ Hits 12978 12981 +3
Misses 14828 14828 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonmaddock
approved these changes
Sep 25, 2025
grmtrkngtn
pushed a commit
that referenced
this pull request
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new switch
force_vmcon_inequality_satisficationthat allows one to turn on "strict" inequality mode: where an additional convergence criteria is added to VMCON that ensures all inequality constraints are exactly satisfied.By default, this will be off (returning PROCESS to how it was pre-#3240).
I have tested this with
large_tokamak_nofwhich is now failing with--reg-tolerance = 0.0; settingforce_vmcon_inequality_satisfication = 1causes the test to pass.