Skip to content

Add configurable inequality tolerance to the VMCON solver#3878

Merged
timothy-nunn merged 1 commit intomainfrom
force-vmcon-tolerance
Oct 13, 2025
Merged

Add configurable inequality tolerance to the VMCON solver#3878
timothy-nunn merged 1 commit intomainfrom
force-vmcon-tolerance

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

Modifies the default behaviour changed recently in #3858. Instead of applying no additional convergence criteria, we will revert back to applying the old inequality convergence criteria but with a default relative tolerance of 1e-8 (was 0 before) that can be modified in the IN.DAT. The option to turn this additional convergence criteria off will remain (introduced in #3858).

@timothy-nunn timothy-nunn self-assigned this Oct 2, 2025
@timothy-nunn timothy-nunn marked this pull request as draft October 2, 2025 13:27
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 46.44%. Comparing base (124a7ee) to head (e14288a).
⚠️ Report is 172 commits behind head on main.

Files with missing lines Patch % Lines
process/solver.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3878   +/-   ##
=======================================
  Coverage   46.44%   46.44%           
=======================================
  Files         123      123           
  Lines       28044    28047    +3     
=======================================
+ Hits        13024    13027    +3     
  Misses      15020    15020           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn force-pushed the force-vmcon-tolerance branch from 449b227 to e14288a Compare October 2, 2025 13:45
@timothy-nunn timothy-nunn marked this pull request as ready for review October 2, 2025 13:54
Copy link
Copy Markdown
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I think this is a good compromise: not completely strict (convergence trouble) but not the original VMCON convergence criterion either (allowed large inequality violations if Lagrange multiplier was small). This gives us the original VMCON convergence criterion whilst additionally ensuring we don't have large inequality violations.

@timothy-nunn timothy-nunn merged commit 4a8a9ea into main Oct 13, 2025
14 of 18 checks passed
@timothy-nunn timothy-nunn deleted the force-vmcon-tolerance branch October 13, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants