Add configurable inequality tolerance to the VMCON solver#3878
Merged
timothy-nunn merged 1 commit intomainfrom Oct 13, 2025
Merged
Add configurable inequality tolerance to the VMCON solver#3878timothy-nunn merged 1 commit intomainfrom
timothy-nunn merged 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3878 +/- ##
=======================================
Coverage 46.44% 46.44%
=======================================
Files 123 123
Lines 28044 28047 +3
=======================================
+ Hits 13024 13027 +3
Misses 15020 15020 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
449b227 to
e14288a
Compare
jonmaddock
approved these changes
Oct 13, 2025
Contributor
jonmaddock
left a comment
There was a problem hiding this comment.
Great, I think this is a good compromise: not completely strict (convergence trouble) but not the original VMCON convergence criterion either (allowed large inequality violations if Lagrange multiplier was small). This gives us the original VMCON convergence criterion whilst additionally ensuring we don't have large inequality violations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the default behaviour changed recently in #3858. Instead of applying no additional convergence criteria, we will revert back to applying the old inequality convergence criteria but with a default relative tolerance of
1e-8(was0before) that can be modified in the IN.DAT. The option to turn this additional convergence criteria off will remain (introduced in #3858).