fix: Makefile now correctly selects the build ID for macos#13
Merged
miguelsanchez-upsun merged 2 commits intomainfrom Mar 11, 2026
Merged
fix: Makefile now correctly selects the build ID for macos#13miguelsanchez-upsun merged 2 commits intomainfrom
miguelsanchez-upsun merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Makefile where the macOS-specific build ID selection was not working correctly. The issue was that GORELEASER_ID was being conditionally modified based on GOOS before GOOS was actually set, causing the macOS detection to always fail.
Key Changes
- Relocated the
GORELEASER_IDdefinition and macOS conditional logic to execute afterGOOSandGOARCHare determined - Changed the assignment operator from
=to:=for the macOS-specific override
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
miguelsanchez-upsun
force-pushed
the
fix/makefile-macos-building
branch
from
c59f89a to
7476d78
Compare
miguelsanchez-upsun
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.