Skip to content

fix: Makefile now correctly selects the build ID for macos #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelsanchez-upsun merged 2 commits into from
Mar 11, 2026
Merged

fix: Makefile now correctly selects the build ID for macos #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8331ad0
fix: Makefile now correctly selects the build ID for macos
Jan 7, 2026
7476d78
feat(make): better handle defaults and overrides for GORELEASER_ID us…
Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
PHP_VERSION = 8.4.16

GORELEASER_ID ?= upsun

ifeq ($(GOOS), darwin)
GORELEASER_ID=$(GORELEASER_ID)-macos
endif

GOOS := $(shell uname -s | tr '[:upper:]' '[:lower:]')
GOARCH := $(shell uname -m)
ifeq ($(GOARCH), x86_64)
Expand All @@ -15,6 +9,14 @@ ifeq ($(GOARCH), aarch64)
GOARCH=arm64
endif

FLAVOR ?= upsun

ifeq ($(GOOS), darwin)
GORELEASER_ID = $(FLAVOR)-macos
else
GORELEASER_ID = $(FLAVOR)
endif

VERSION := $(shell git describe --always)

# Tooling versions
Expand Down
Loading