fix: handle v-prefix in installer.sh for GoReleaser asset filenames#24
Merged
miguelsanchez-upsun merged 5 commits intomainfrom Mar 11, 2026
Merged
Conversation
GoReleaser strips the v prefix from asset filenames but keeps it in the tag/release path. The installer was using the tag name (with v) for both, causing 404s when downloading. Introduce a `tag` variable (always v-prefixed, for release URLs) and a `version` variable (without v, for asset filenames). Handles both `VERSION=5.10.0` and `VERSION=v5.10.0` from users. Closes CLI-112 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes the installer’s GitHub download URL construction so it uses a v-prefixed tag for the release path while using a non-prefixed version string for GoReleaser asset filenames.
Changes:
- Split
tag(v-prefixed) vsversion(nov) incheck_version(). - Normalize user-provided
VERSIONto accept both5.x.yandv5.x.y. - Update raw install download URL to use
${tag}for the release directory and${version}for the asset filename.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
If /releases/latest returns nothing and no VERSION is specified, the installer would proceed with an empty version and fail later with a confusing error. Fail early with a clear message instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The version lookup now uses the GitHub API via github_curl, which supports GITHUB_TOKEN authentication. This avoids rate limiting on shared hosting where many users may run the installer. If no stable release exists (404), the tag will be empty and the existing version check will fail gracefully with a clear error. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
miguelsanchez-upsun
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GoReleaser strips the
vprefix from asset filenames but keeps it in the tag/release URL path. The installer was using the raw tag name for both, producing URLs like:tag(v-prefixed, for release path) andversion(no prefix, for filenames) variablesVERSIONto handle both5.10.0andv5.10.0Found during the first pre-release on the new repo (
v5.10.0-alpha1).🤖 Generated with Claude Code