Skip to content

fix: handle v-prefix in installer.sh for GoReleaser asset filenames #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelsanchez-upsun merged 5 commits into from
Mar 11, 2026
Merged

fix: handle v-prefix in installer.sh for GoReleaser asset filenames #24

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71da719
fix: handle v-prefix in installer.sh for GoReleaser asset filenames
pjcdawkins Mar 11, 2026
2f0988a
fix: fail early if CLI version cannot be determined
pjcdawkins Mar 11, 2026
eb17435
fix: use parameter expansion instead of echo|sed for v-prefix strip
pjcdawkins Mar 11, 2026
a2fc2bf
fix: use github_curl for version lookup to support GITHUB_TOKEN
pjcdawkins Mar 11, 2026
d2217b3
Merge branch 'main' into cli-112-fix-installersh-v-prefix-mismatch
miguelsanchez-upsun Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions installer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ footer_notes=""
has_sudo=""
kernel=""
machine=""
tag=""
version=""
package="upsun-cli"
docs_url="https://docs.upsun.com"
Expand Down Expand Up @@ -271,11 +272,29 @@ check_ca_certificates() {

check_version() {
if [ -z "${VERSION}" ]; then
version=$(curl -I https://github.com/upsun/cli/releases/latest 2>/dev/null | awk -F/ -v RS='\r\n' '/upsun.cli.releases.tag/ {printf "%s", $NF}')
tag=$(github_curl https://api.github.com/repos/upsun/cli/releases/latest 2>/dev/null | sed -n 's/.*"tag_name"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/p' | head -n 1)
else
tag=${VERSION}
fi

# Ensure the tag has the v prefix (for GitHub release URLs).
case "$tag" in
v*) ;;
*) tag="v${tag}" ;;
esac

# The version without the v prefix (for asset filenames).
version=${tag#v}

if [ -z "$version" ]; then
output " [ ] ERROR: Could not determine CLI version" "error"
exit_with_error
fi

if [ -z "${VERSION}" ]; then
output " [*] No version specified, using latest ($version)" "success"
else
output " [*] Version ${VERSION} specified" "success"
version=${VERSION}
output " [*] Version ${version} specified" "success"
fi
}

Expand Down Expand Up @@ -608,7 +627,7 @@ install_raw() {
# Start downloading the right version
output "\nDownloading the $vendor_name CLI" "heading"

url="${URL}/${version}/${binary}_${version}_${kernel}_${machine}.tar.gz"
url="${URL}/${tag}/${binary}_${version}_${kernel}_${machine}.tar.gz"
output " Downloading ${url}";
tmp_dir=$(mktemp -d)
tmp_name="$binary-"$(date +"%s")
Expand Down
Loading