Removed use of any.#70
Merged
shubhbapna merged 9 commits intoutmgdsc:dev/gdsc-open-source-2022from Oct 31, 2022
Merged
Conversation
Referencing issue utmgdsc#63
shubhbapna
requested changes
Oct 10, 2022
Collaborator
shubhbapna
left a comment
shubhbapna
left a comment
There was a problem hiding this comment.
Good job! Left some comments please review.
Also please follow the PR template especially for testing.
Co-Authored-By: Shubh Bapna <38372682+shubhbapna@users.noreply.github.com>
ggggg
requested review from
embeddedt and
shubhbapna
and removed request for
embeddedt,
hiimchrislim and
shubhbapna
huonggiangbui
requested review from
embeddedt and
hiimchrislim
and removed request for
embeddedt
shubhbapna
requested changes
Oct 17, 2022
Collaborator
shubhbapna
left a comment
shubhbapna
left a comment
There was a problem hiding this comment.
Almost there :)
Is it possible to remove undefined from the getPollStatus, getResult and getUser arguments? This is because in the routers we are already performing a type check and are returning a 400 if it fails. So if we can combine the type check with the check for undefined, we can reduce the duplicate code
Collaborator
Author
Good catch! Fixed :) |
shubhbapna
requested changes
Oct 18, 2022
Collaborator
shubhbapna
left a comment
shubhbapna
left a comment
There was a problem hiding this comment.
Sorry for being picky
ggggg
added a commit
to ggggg/PollVotingSystem
that referenced
this pull request
Oct 31, 2022
This was missed in utmgdsc#70 after pull request suggestions.
ggggg
added a commit
to ggggg/PollVotingSystem
that referenced
this pull request
Oct 31, 2022
This was missed in utmgdsc#70 after pull request suggestions.
This was referenced Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Issue #63
Proposed Changes
anyTests
Please describe the tests that you ran to verify your changes.
yarn run buildto make sure no type errors are caused