Skip to content

Added missing import statement#80

Merged
shubhbapna merged 2 commits intoutmgdsc:dev/gdsc-open-source-2022from
ggggg:Added-missing-import-statement
Nov 4, 2022
Merged

Added missing import statement#80
shubhbapna merged 2 commits intoutmgdsc:dev/gdsc-open-source-2022from
ggggg:Added-missing-import-statement

Conversation

@ggggg
Copy link
Collaborator

@ggggg ggggg commented Oct 31, 2022

This template is a simple version of Zulip PR template: https://github.com/zulip/zulip/

This was missed in #70 after pull request suggestions.
Sorry for all the PR spam, I couldn't get it to base the branch of the 2022 branch instead of main.
Fixes: N/A

Screenshots and screen captures:

Self-review checklist

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review:

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes (what you are trying to accomplish? e.g. don't let user's age less than 0).

Completed manual review and testing of the following (please attach screenshots/gifs for UI changes and commit your test cases for functionality changes):

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@ggggg ggggg changed the base branch from main to dev/gdsc-open-source-2022 October 31, 2022 04:02
@shubhbapna
Copy link
Collaborator

shubhbapna commented Nov 2, 2022

ahhhh. is it ready to be merged?

Please run the server and check manually its working

@ggggg
Copy link
Collaborator Author

ggggg commented Nov 2, 2022

I believe so, please review it first.

@ggggg ggggg marked this pull request as ready for review November 2, 2022 01:38
@ggggg
Copy link
Collaborator Author

ggggg commented Nov 2, 2022

Sorry didnt notice it was still on draft.

Copy link
Collaborator

@shubhbapna shubhbapna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubhbapna shubhbapna merged commit 36aadac into utmgdsc:dev/gdsc-open-source-2022 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants