Added missing import statement#80
Merged
shubhbapna merged 2 commits intoutmgdsc:dev/gdsc-open-source-2022from Nov 4, 2022
Merged
Added missing import statement#80shubhbapna merged 2 commits intoutmgdsc:dev/gdsc-open-source-2022from
shubhbapna merged 2 commits intoutmgdsc:dev/gdsc-open-source-2022from
Conversation
Collaborator
|
ahhhh. is it ready to be merged? Please run the server and check manually its working |
Collaborator
Author
|
I believe so, please review it first. |
Collaborator
Author
|
Sorry didnt notice it was still on draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This template is a simple version of Zulip PR template: https://github.com/zulip/zulip/
This was missed in #70 after pull request suggestions.
Sorry for all the PR spam, I couldn't get it to base the branch of the 2022 branch instead of main.
Fixes: N/A
Screenshots and screen captures:
Self-review checklist
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review:
Completed manual review and testing of the following (please attach screenshots/gifs for UI changes and commit your test cases for functionality changes):