Remove Try/Catch to allow for error handling above library #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meldiron
reviewed
Nov 27, 2023
Contributor
Meldiron
left a comment
Meldiron
left a comment
There was a problem hiding this comment.
Found some more places:
- https://github.com/utopia-php/analytics/blob/feat-fix-silent-fails/src/Analytics/Adapter/HubSpot.php#L202-L215
- https://github.com/utopia-php/analytics/blob/feat-fix-silent-fails/src/Analytics/Adapter/HubSpot.php#L113-L125
Let's also please do QA and attach a screenshot to PR
Meldiron
approved these changes
Nov 27, 2023
Contributor
Author
|
Quickly added an orbit patch for sub props in this, please re-review |
Contributor
Author
|
Closing due to #51 handling most of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.