Skip to content

Conversation

@PineappleIOnic
Copy link
Contributor

@PineappleIOnic PineappleIOnic commented Feb 16, 2024

Currently we use a logError function to handle exceptions, this removes my ability to better handle it on where we use the library so this PR removes that and just throws directly to give us better visibility when things go wrong.

This PR also addresses:

  • Made the plausble validate() method use type instead of name
  • Moved tests over to GitHub actions and parallelised them
  • Changes the hubspot contactExists function to use get contact with email propertyId instead of search this should cover edge cases where users have multiple emails assigned to one contact

@PineappleIOnic PineappleIOnic changed the title Remove Error Handling Various Fixes and Improvements for Analytics Feb 16, 2024
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants