-
Notifications
You must be signed in to change notification settings - Fork 55
Added tenant to the result in find so that result contains tenant and we get access to tenant in the document #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@ArnabChatterjee20k has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 59 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThe changes update the MariaDB and Postgres adapters' Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/Database/Adapter/MariaDB.php(1 hunks)tests/e2e/Adapter/Scopes/DocumentTests.php(1 hunks)
🔇 Additional comments (2)
src/Database/Adapter/MariaDB.php (1)
1662-1666: LGTM! Critical fix for tenant data accessibility.This change correctly ensures that the processed
$tenantfield is assigned back to the results array. Without this line, the tenant information would be processed but lost, which could break tenant isolation in multi-tenant applications using shared tables.The fix follows the established pattern used for other internal fields (
$id,$sequence, etc.) and resolves the issue described in the PR objectives.tests/e2e/Adapter/Scopes/DocumentTests.php (1)
4248-4251: ```shell
#!/bin/bashLocate Query::select implementation with accurate line number
echo "🔍 Locating Query::select definition with line number:"
rg -n "public static function select" src/Database/Query.php | head -n1LINE=$(rg -n "public static function select" src/Database/Query.php | head -n1 | cut -d: -f1)
echo
echo "📄 Showing Query::select implementation (from line $LINE):"
sed -n "${LINE},$((LINE+20))p" src/Database/Query.php</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Summary by CodeRabbit