Skip to content

Conversation

@fogelito
Copy link
Contributor

@fogelito fogelito commented Jul 16, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Tenant identifier fields now retain their original data type in returned documents, rather than being automatically converted to integers.
  • Refactor

    • Improved document creation and type casting to ensure internal attributes are properly handled and cast alongside collection attributes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 16, 2025

"""

Walkthrough

The changes remove integer casting of the _tenant field in MariaDB, Postgres, and SQL adapters, preserving the original type when assigning it to the $tenant key in documents. Additionally, the Database class now invokes type casting after relationship population during document creation and includes internal attributes in the casting process.

Changes

File(s) Change Summary
src/Database/Adapter/MariaDB.php
src/Database/Adapter/Postgres.php
src/Database/Adapter/SQL.php
Removed integer casting of _tenant when assigning to $tenant in documents; now assigns the raw value.
src/Database/Database.php Added type casting after relationship population in document creation; merged internal attributes during casting.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Database
    participant Adapter

    Client->>Database: createDocument()
    Database->>Database: Populate relationships
    Database->>Database: casting() (with internal + collection attributes)
    Database->>Adapter: Store document
    Adapter-->>Database: Confirmation
    Database-->>Client: Created document (with proper casting)
Loading

Possibly related PRs

Poem

In the fields where tenants dwell,
We let their types now freely tell.
No more forced to be an int,
The code is cast with subtle hint.
With every doc and every row,
The rabbit cheers, "Let data flow!" 🐇
"""


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80b8edd and 3d809c8.

📒 Files selected for processing (2)
  • src/Database/Adapter/SQL.php (1 hunks)
  • src/Database/Database.php (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/Database/Adapter/SQL.php
  • src/Database/Database.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Adapter Tests (SharedTables/SQLite)
  • GitHub Check: Adapter Tests (SharedTables/MySQL)
  • GitHub Check: Adapter Tests (SharedTables/Postgres)
  • GitHub Check: Adapter Tests (SharedTables/MariaDB)
  • GitHub Check: Adapter Tests (MariaDB)
  • GitHub Check: Adapter Tests (SQLite)
  • GitHub Check: Adapter Tests (Postgres)
  • GitHub Check: Adapter Tests (Pool)
  • GitHub Check: Adapter Tests (Mirror)
  • GitHub Check: Adapter Tests (MySQL)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fogelito fogelito requested a review from abnegate July 16, 2025 07:02
Copy link
Member

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work okay from Appwrite?

@fogelito
Copy link
Contributor Author

Tested on Appwrite
Tested on Cloud for shared tables v1 v2 + Non shared tables.

@fogelito fogelito requested a review from abnegate July 20, 2025 15:53
@abnegate abnegate merged commit 363ee53 into main Jul 21, 2025
15 checks passed
@abnegate abnegate deleted the cast-internals branch July 21, 2025 01:18
@coderabbitai coderabbitai bot mentioned this pull request Aug 6, 2025
@coderabbitai coderabbitai bot mentioned this pull request Sep 14, 2025
@coderabbitai coderabbitai bot mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants