groups: fixes to pass GNU's Testsuite#2446
Merged
sylvestre merged 3 commits intouutils:masterfrom Jun 23, 2021
Merged
Conversation
* add support for multiple users * sync help text with GNU's `groups` manpage
sylvestre
reviewed
Jun 21, 2021
56d832d to
8813cbe
Compare
rivy
suggested changes
Jun 22, 2021
Contributor
rivy
left a comment
There was a problem hiding this comment.
Some nits.
And thanks for tackling this issue!
Contributor
Author
|
@rivy Thanks for your feedback and doing the review. |
8813cbe to
2736ef8
Compare
Contributor
|
Clippy isn't happy |
2736ef8 to
981c0ce
Compare
Contributor
|
Cool |
Contributor
Author
|
@sylvestre #2361 also brought two new PASSES, but those were way harder to achieve. |
981c0ce to
8eb27fa
Compare
jhscheer
added a commit
to jhscheer/coreutils
that referenced
this pull request
Jun 23, 2021
* change of identifier names and spelling according to the suggestions in the review of uutils#2446
8eb27fa to
11f36ea
Compare
rivy
approved these changes
Jun 23, 2021
Contributor
|
If you don't mind, rebase this off of #2452 when it's merged and the spelling errors will be fixed. Thanks for the work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This passes the relevant tests for
groupsfrom GNU's Testsuite that currently fail on master branch.groupsmanpage