fix broken pipe error in tests/common/util#3910
Merged
sylvestre merged 2 commits intouutils:mainfrom Sep 12, 2022
Merged
Conversation
Collaborator
|
Interesting! How did you get to this solution and why does it work? |
Contributor
Author
|
Yes it is. I came to this solution because I usually use a buffer like BufReader or BufWriter around a bare Stdin, Stdout etc. to reduce system calls and improve performance. I tried different things, but this one stopped the test failing. However, I'm not sure about the reason. I guess it's because the BufWriter calls |
sylvestre
force-pushed
the
3895-fix-broken-pipe-error-in-utils
branch
2 times, most recently
from
462d68a to
07b04b0
Compare
sylvestre
force-pushed
the
3895-fix-broken-pipe-error-in-utils
branch
from
07b04b0 to
795ab1f
Compare
Contributor
Author
|
Is tests/common/util somehow involved in the gnu tests? |
Contributor
|
No, we have this test failing from time to time (tee) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3895