Disable test_when_piped_input_then_no_broken_pipe by default#4005
Merged
tertsdiepraam merged 3 commits intouutils:mainfrom Oct 4, 2022
sylvestre:disable-expensive-test
Merged
Disable test_when_piped_input_then_no_broken_pipe by default#4005tertsdiepraam merged 3 commits intouutils:mainfrom sylvestre:disable-expensive-test
tertsdiepraam merged 3 commits intouutils:mainfrom
sylvestre:disable-expensive-test
Conversation
It is blocking the executions of the tests and I suspect it is breaking android
Contributor
Author
|
Android is green again \o/ |
Contributor
|
Sorry. Yes, this test is pretty expensive and brute force. Perhaps, there is a more specific problem behind the randomness of the failures? |
Contributor
Author
|
dunno but I haven't seen it failed for a while :) |
Contributor
|
However, nice :) Maybe it helps. At the time of writing the test in #3910, I haven't figured out why it actually failed. The fix attached to the test just stopped it failing with |
This was referenced Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is blocking the executions of the tests and I suspect it is breaking android