mv: Adding fixes for i-3 GNU tests related to tty output when file is not writeable#9599
mv: Adding fixes for i-3 GNU tests related to tty output when file is not writeable#9599sylvestre merged 7 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #9599 will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
|
Same as with the other PR's that codspeed is just being flaky. Should be ready for another round of review |
|
I'm curious on your take with the cleaning up of the readability of the tests? I'm finding that theres a mismatch of integration test styles in every folder and that its cleaner when you do something like: compared to: But I know its frowned upon to do these types of large scale refactors on projects like this, would you mind if I go through the tests and make them match the top format with the stderr matching on the ucmd and adding the macros for creating the test env? |
eec091e to
2d9b035
Compare
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
f048979 to
28ac11f
Compare
|
GNU testsuite comparison: |
470ef16 to
9c2c1ea
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
7a15896 to
101b9da
Compare
|
GNU testsuite comparison: |
… not writeable (uutils#9599) * Adding fixes for i-3 GNU tests related to tty output when file is not writeable * Removed translation zero stripping hack and fixed clippy and spelling errors * Removed unused windows import * Addressing comments and cleaning up tests * Spellcheck fixes * Replacing helper function in other places too * mv: address review comments - reorder enum, cache mode, safer defaults du: fix count_link only working with -a du: fix count_link only working with -a (linux)
Discovered when automating the stty test discovery on the github CI that the reason this test was failing was because it required to be run with an interactive tty, the logic is that when the -i flag is not provided and a file is piped in but it is not writable the GNU implementation prints an output to the tty.
Its exciting that this is the last mv test thats not passing.