mv: show file mode in interactive prompt for read-only targets#9846
mv: show file mode in interactive prompt for read-only targets#9846skjha98 wants to merge 2 commits intouutils:mainfrom
Conversation
25bb328 to
a3c766a
Compare
|
GNU testsuite comparison: |
|
I have a similar pr for this, going to compare the two today later because I'm sure I've missed something #9599 |
|
Thanks, @ChrisDryden I'm quite new to Rust and this is my second contribution to uutils (and open source in general), so I'm happy to learn from the comparison. I put this together to address the GNU i-3 failure specifically. I also noticed that the Fluent engine strips leading zeros from octal numbers, so I used a invisible character(\u{200c}) as a workaround to keep it as 0444 instead of 444. Looking forward to your thoughts! |
|
GNU testsuite comparison: |
|
Could you please fix the conflicts? Thanks |
|
I see that i-3 is now passing on the main coverage page thanks to @ChrisDryden PR. Since the issue is resolved, I'll close this PR. It was a great learning experience for my first contribution to uutils—thanks everyone! |
Description
Fixes the GNU compatibility gap where
mv -ifails to show the octal mode and permission string when prompting to overwrite a read-only file (GNU test i-3).Key Changes
mv.rsto detect files lacking owner-write bits.(\u{200c})in the octal string to prevent Fluent from stripping the leading zero (e.g., ensuring0444doesn't display as444).mv-prompt-overriding-modetoen-USandfr-FRlocales.Verification
mv: overwrite 'dest'?mv: overwrite 'dest', overriding mode 0400 (r--------)?clippyandfmtare clean.