add a new from_str_at_date(date, string) function#2
Merged
sylvestre merged 4 commits intouutils:mainfrom May 11, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2 +/- ##
==========================================
+ Coverage 70.54% 71.47% +0.92%
==========================================
Files 2 2
Lines 275 312 +37
Branches 66 75 +9
==========================================
+ Hits 194 223 +29
Misses 39 39
- Partials 42 50 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sylvestre
force-pushed
the
from_str_at_date
branch
from
2002c69 to
f24b5ed
Compare
Contributor
Author
|
AFAIK, not needed for coreutils (yet?) but an interesting features |
cakebaker
reviewed
May 11, 2023
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
cakebaker
reviewed
May 11, 2023
cakebaker
reviewed
May 11, 2023
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
cakebaker
approved these changes
May 11, 2023
Collaborator
cakebaker
left a comment
cakebaker
left a comment
There was a problem hiding this comment.
It's a bit an unusual approach to delegate from from_str_at_date to from_str instead of the other way around I expected to see before starting the review.
cakebaker
added a commit
that referenced
this pull request
Aug 16, 2025
(jiff series #2) refactor: optimize time type sizes and add conversion from `Time` to `jiff::civil::Time`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.