Conversation
14c922d to
3199b5b
Compare
This pr should fix the issue with the timezones uutils#36. Now all tests are passing.
3199b5b to
ff0e728
Compare
|
Interesting! I think the tests should be run with always the same dates and timezones as reference, so |
|
Here's the culprit for at least one of them: Line 203 in ff0f99b Is it just me or is that function a bit weird? It doesn't do anything with the date being passed in during parsing. It just offsets the duration at the end, but that's a strange use case isn't it? Edit: We're not using it in coreutils either. So I'm not sure why it's there. Edit 2: It comes from here: #2. @sylvestre what do you think, should we simplify this back to one function? I'm not sure I see the use case here. At least until we start taking the date into account for computing the actual offset like in https://github.com/uutils/parse_datetime/pull/28/files. |
|
heu, not sure, sorry :) |
|
I am closing this until we find a better solution / refactor it. |
This pr should fix the issue with the timezones #36. Now all tests are passing.
I am not sure whether the logic is correct or we should rather change the tests.